Conversation
Owner
Author
|
Вроде сделал все правильно. |
dirtymew
suggested changes
Feb 11, 2025
dirtymew
left a comment
dirtymew
left a comment
There was a problem hiding this comment.
Юрий
есть еще что исправить
на будущее - лучше чтобы весь процесс ревью был в одном PR
| func (r Running) TrainingInfo() InfoMessage { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return InfoMessage{ |
There was a problem hiding this comment.
теперь тут неверно
см задание
Для реализации этого метода для структуры Running{} нужно вернуть вызов такого же метода TrainingInfo(), только для структуры Training{}. Вспомните, как вызывать методы встроенной структуры.
| func (w Walking) TrainingInfo() InfoMessage { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return InfoMessage{ |
| // вставьте ваш код ниже | ||
| ... | ||
| var meanSpeedInMInSec float64 = math.Pow(w.meanSpeed()*KmHInMsec, 2) | ||
| return (CaloriesWeightMultiplier*w.Weight + (meanSpeedInMInSec/(w.Height/CmInM))*CaloriesSpeedHeightMultiplier*w.Weight) * w.Duration.Hours() * MinInHours |
| // вставьте ваш код ниже | ||
| ... | ||
|
|
||
| return InfoMessage{ |
dirtymew
approved these changes
Feb 13, 2025
dirtymew
left a comment
dirtymew
left a comment
There was a problem hiding this comment.
Юрий
работу принимаю
но есть замечания по исправлениям - обрати внимание
| func (s Swimming) TrainingInfo() InfoMessage { | ||
| // вставьте ваш код ниже | ||
| ... | ||
| return s.Training.TrainingInfo() |
There was a problem hiding this comment.
тут было верно - зачем исправил ?
return InfoMessage{
TrainingType: s.TrainingType,
Duration: s.Duration,
Distance: s.distance(),
Speed: s.meanSpeed(),
Calories: s.Calories(),
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ВОт сейчас точно заработает